Seeking feedback on a new screen shake feature

[BigBuckBunny]

Using the camera shakes when there is an explosion effect is an interesting concept, but using a bowling ball on another kart and getting a shake effect as a result looks strange to me. In general, like with the PR for speed-based shakes, I'm not fond of this effect.

Does the shake also apply when your kart is actually being exploded?

My initial idea was to trigger the screen shake only for actual explosion effects. In the code, I added the shake inside Flyable::explode, but I later realized that not only the Cake item but also the Bowling Ball inherits from Flyable, which is why the shake was applied to both. It didn’t feel too bad to me, but I understand your point.

To answer your question: no, the camera animation that plays when your own kart is hit currently doesn't include any shake effect.

I could try the following:

• Restrict the shake effect to real explosions only (I’ll need to find the appropriate place in the codebase to hook into).
  
• Test adding a shake effect specifically when your own kart is exploded.